[
https://issues.apache.org/jira/browse/QPID-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987486#action_12987486
]
Robbie Gemmell commented on QPID-3017:
--------------------------------------
Hi Keith,
Thanks for this, I had a look over the patches and they seem good. There are
some small updates I'd suggest:
- In AutoCommittransaction, one of the enqueue methods logs that it is
dequeing instead of enqueing.
- I would ensure the log messages convey that it is a store/transaction log
dequeue being performed, as that logging isn't output for transient messages
which isn't clear from the text.
- The patches introduced whitespace after the penultimate closing brace in
LocalTransaction.beginTranIfNecessary()
- AMQException is now being caught in LocalTransaction.commit() instead of
Exception. Given that any type of exception really indicates a need to clean up
the transaction, I think it should still be catching Exception there.
An additional patch just for updates to the originals is fine, easier even as
it makes the changes obvious and I'll just squash them together at commit time.
Robbie
> Add unit tests and improve error handling for classes within
> org.apache.qpid.server.txn
> ---------------------------------------------------------------------------------------
>
> Key: QPID-3017
> URL: https://issues.apache.org/jira/browse/QPID-3017
> Project: Qpid
> Issue Type: Task
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8
> Environment: N/A
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.9
>
> Attachments:
> 0001-QPID-3017-Unit-tests-for-new-transaction-classes-in-.patch,
> 0002-QPID-3017-Added-javadoc-and-logging.-Removed-todos.patch,
> 0003-QPID-3017-Added-unit-tests-for-new-LocalTransaction-.patch
>
>
> The following new transaction classes:
> org.apache.qpid.server.txn.LocalTransaction
> org.apache.qpid.server.txn.AutoCommitTransaction
> org.apache.qpid.server.txn.ServerTransaction
> added for 0-10 currently have no unit tests and there are several TODOs
> flagged in the error handling logic.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
