I think trying to clean up how people use the codebase is a good idea, no question about that. However, as there is already a ConnectionFactory implementation that people simply miss/ignore already when overlooking/ignoring JNDI I do wonder if providing a ConnectionFactory..Factory..is actually going to change their behaviour?
Robbie On 7 February 2011 17:00, Rajith Attapattu <[email protected]> wrote: > So far I have only heard positive comments about this approach. > Does anybody have any concerns about the approach in general or any comments > about how it should be done if it's needed ? > > I am hoping to create a JIRA on this soon abd perhaps attach a very simple > patch. > And if there are no objections, I will be tempted to commit it by the end of > the week. > > I'd like to make sure we get it right as we need to provide a stable > interface between releases going forward. > Therefore I urge all interested folks to voice in their concerns/opinions at > the earliest possible. > > Regards, > > Rajith. > > On Mon, Feb 7, 2011 at 10:46 AM, Andrew Stitcher <[email protected]>wrote: > >> On Fri, 2011-02-04 at 11:22 -0500, Rajith Attapattu wrote: >> > Hi, >> > >> > Some Qpid users like to create connections and destinations dynamically >> > instead of using the jndi.properties file. >> > All though there is a reasonable way of creating Queues and Topics using >> > session.createQueue and session.createTopic respectively, there is >> currently >> > no proper way of creating connections. >> > >> > Therefore people resort to using AMQConnection class., which is less than >> > ideal. >> > Chances are that this class can change, get deprecated in favour of a >> better >> > implementation etc.. in a future release. >> > >> > Perhaps we should provide a stable API for creating connections without >> > having to use internal implementation specific classes for folks who want >> to >> > do it dynamically. >> > Maybe something along the lines of, >> > >> > Qpid { >> > >> > public javax.jms.ConnectionFactory createConnectionFactory(String user, >> > String password); >> > >> > public javax.jms.ConnectionFactory createConnectionFactory(String url); >> > >> > public javax.jms.Connection createConnection(String user, String >> password); >> > >> > public javax.jms.Connection createConnection(String url); >> > >> > public javax.jms.Destination(String addr); >> > >> > } >> > >> > That way we can shield a Qpid user from changes in a reasonable way. >> > However we need to impress upon our users that the preferred way is to >> use >> > the JNDI mechanism. >> > On the other hand users could use the above mechanism to create >> connections >> > and destinations and inject them into their preferred JNDI mechanism >> rather >> > than using our JNDI implementation. >> >> An important place where this would be used would be infrastructure >> code; a good example would be the JCA adapter. >> >> Andrew >> >> >> >> --------------------------------------------------------------------- >> Apache Qpid - AMQP Messaging Implementation >> Project: http://qpid.apache.org >> Use/Interact: mailto:[email protected] >> >> > > > -- > Regards, > > Rajith Attapattu > Red Hat > http://rajith.2rlabs.com/ > --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
