+1
On 02/14/2011 11:53 AM, Robbie Gemmell wrote:
For those who didn't follow the recent discussion, I recently raised
the issue of our poor use of JIRA and inclusion of JIRA references
within svn commit log messages. A quick check of the prior 3 months
commits showed barely over 30% of them had a JIRA reference, which is
far lower than it should have been.
During the discussion I suggested we add a pre-commit hook to enforce
use of JIRA references where appropriate. One suggestion I made was
that this would block all commits that don't have a Qpid JIRA
reference unless they instead contained eg 'NO-JIRA', which could be
used to bypass the hook on demand. Any commit which failed to meet
these cases would be rejected with a message alerting the committer
how to resolve the issue, i.e. include a JIRA reference if appropriate
or signal their intent to bypass the requirement. This means noone
would ever be prevented from committing what they want when they want,
but still removes the possibility of JIRA references being left out
due to merely forgetting them, and means that if/when we later review
the commits we can identify where people have chosen to purposely
bypass the requirement.
I haven't seen any objections to such a system, but to ensure everyone
gets a say I wanted to call this vote to establish the way forward. As
per indication at http://www.apache.org/foundation/voting.html the
vote will be conducted on a majority rules basis, and I propose that
the vote is open equally to all committers and not just PMC members.
The vote will close at 5pm GMT on Thursday 17th February (i.e. approx
72hrs from now).
Please reply with your +1 / -1 vote, or cross one of the boxes below:
[ ] +1, I accept the proposal and vote to add the svn pre-commit
hook as outlined above.
[ ] -1, I reject the proposal and vote not to add the svn pre-commit
hook outlined above.
Regards,
Robbie
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
