On Tue, Feb 15, 2011 at 12:43 PM, Emmanuel Bourg <[email protected]> wrote:
> Le 15/02/2011 17:21, Rajith Attapattu a écrit : > > Hi All, >> >> It seems there is good support for adding a pre-commit hook for checking >> JIRA reference. >> While we are at it, I'd like to draw your attention to another problem >> that >> makes a release managers job unnecessarily tedious. >> >> We all have been guilty of adding files to the svn repo without the >> mandatory license header. >> >> I believe there is a good case for adding a pre commit hook that checks >> the >> license header when adding new files. >> We also need to have a mechanism to ensure certain files get exempted from >> this check. >> >> Thoughts ? >> > > IMHO this is better handled at release time with tools like RAT. Adding too > many hurdles to commits will quickly turn the development into a frustrating > experience. > Well I had to patch RAT and run my own custom version to catch all the issues. I have acted as release manager twice and as backup/stand-in several times and I can tell you it's not a particularly pleasant task to fix all the licensing headers. Besides this check will only affect when we add a new file - how often do we add new files ? If we think about it, not that too often. Most commits are for existing files. So I disagree that this will make committing changes a frustrating experience. Rajith. > > Emmanuel > > -- Regards, Rajith Attapattu Red Hat http://rajith.2rlabs.com/
