[
https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011975#comment-13011975
]
Keith Wall commented on QPID-3166:
----------------------------------
Hi Robbie
Looks good, just a couple of comments.
1) You don't explain why it is necessary to bias the distribution of the
messages.
2) Thread safety issue with _failMsg means we might fail to see the assertNull
when we should. I see that latch will still mean the test fail but the
threading issue might obscure the underlying cause. Making _failMsg volatile
(or atomicref) would be resolve the issue.
3) I think your javadoc would be better moved down to method level rather than
class level.
> add system test using multiple producers with batched transactions and
> multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3166
> URL: https://issues.apache.org/jira/browse/QPID-3166
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Tests
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and
> multiple consumers with unique selectors
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
