On Wed, Mar 30, 2011 at 3:36 AM, Andrew Stitcher <astitc...@redhat.com> wrote: > On Tue, 2011-03-29 at 19:14 +1100, Paul Colby wrote: >> Hi all, >> >> I'd love to get https://issues.apache.org/jira/browse/QPID-3027 >> committed, if that's possible. >> >> I've created a review request https://reviews.apache.org/r/462/, but >> no takers yet... ;) > > There's no actual diff to review attached to the reviewboard item. > [That makes it harder to review :)] >
doh! I hadn't noticed the option to attach a diff in the review board! (I'd just assumed that we're supposed to attach diffs to an associated JIRA issue instead). Fixed now :) Thanks, Paul. --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org