On Tue, Mar 29, 2011 at 11:27 PM, Robert Godfrey <[email protected]>wrote:
> > > On 29 March 2011 19:31, Rajika Kumarasiri <[email protected]> wrote: > >> BTW, >> I have a one last question on the patch. I have registered SSL protocol >> handler as the last handler in the chain where you have registered as the >> first ( see below for the diff). Please also refer [0]. And yes I tested >> with following changes. >> >> Rajika >> >> @@ -363,7 +367,9 @@ >> { >> if (_sslFactory != null) >> { >> - >> protocolSession.getFilterChain().addBefore("protocolFilter", "sslFilter", >> +// >> protocolSession.getFilterChain().addBefore("protocolFilter", "sslFilter", >> +// new >> SSLFilter(_sslFactory.buildServerContext())); >> + protocolSession.getFilterChain().addLast("sslFilter", >> new SSLFilter(_sslFactory.buildServerContext())); >> >> >> [0] - >> http://svn.apache.org/repos/asf/mina/trunk/mina-example/src/main/java/org/apache/mina/example/echoserver/Main.java >> >> >> > > To be completely honest on debugging I found that there was only one filter > in the chain at the point this code gets called... I just thought that > "first" for the SSL filter seemed more sensible that "last" (since you want > SSL decrypt before anything else) and so that's what I tried... it worked... > and I gave it no more thought :-) > > +1. Are you planning to port this changes to trunk? I think this patch is good to apply. Rajika
