improvements to QueueRunner
---------------------------
Key: QPID-3183
URL: https://issues.apache.org/jira/browse/QPID-3183
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Priority: Trivial
Fix For: 0.11
Comments from Keith Wall while reviewing QPID-3167, raised as a separate issue
for resolution:
No comments against your actual changes but:
1) I think we should take this opportunity to add some class javadoc to the
newly extracted QueueRunner.
2) In QueueRunner, _logger.error(e) is going to fail to log the underlying(s)
in the broker log. This can make problem determination harder. Would be better
to use the two argument form error(message,throwable)
3) I notice SubFlushRunner made its instance variables explicitly final. I
think QueueRunner ought to have done the same. I think the stricter form is
preferable.
I realise all of the above would have applied to code base prior to your change.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
