[
https://issues.apache.org/jira/browse/QPID-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022214#comment-13022214
]
jirapos...@reviews.apache.org commented on QPID-3222:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/627/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Alan Conway, Chug Rolke, and Steve
Huston.
Summary
-------
Fixes ttl overflow on the broker. Added equality operator for
qpid::messaging::Duration (needed it in test and seemed generally valuable).
This addresses bug QPID-3222.
https://issues.apache.org/jira/browse/QPID-3222
Diffs
-----
/trunk/qpid/cpp/include/qpid/messaging/Duration.h 1090157
/trunk/qpid/cpp/src/qpid/broker/Message.cpp 1090157
/trunk/qpid/cpp/src/qpid/messaging/Duration.cpp 1090157
/trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1090157
Diff: https://reviews.apache.org/r/627/diff
Testing
-------
New test added, make check passes.
Thanks,
Gordon
> Potentially TTL Overflow
> ------------------------
>
> Key: QPID-3222
> URL: https://issues.apache.org/jira/browse/QPID-3222
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Reporter: Jerome Ajot
> Assignee: Gordon Sim
> Labels: ttl
>
> When a message TTL is set by the client to Duration::FOREVER, the message is
> not reachable anymore.
> Every addition and multiplication to the TTL/Expiration Time should check to
> avoid uint64_t overflow.
> For example: broker/Message.cpp: Message::setTimestamp() overflows the
> uint64_t.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
