On Tue, Apr 26, 2011 at 10:00 AM, Robert Godfrey
<[email protected]> wrote:
> On 26 April 2011 15:47, Rajith Attapattu <[email protected]> wrote:
>
>> On Mon, Apr 25, 2011 at 8:03 AM, Danushka Menikkumbura
>> <[email protected]> wrote:
>> > Hi,
>> >
>> > I get the following warning message on the client side for each client
>> call
>> > i make.
>> >
>> > [2011-04-25 13:25:10,177]  WARN
>> > {org.apache.qpid.transport.ClientDelegate} -  Ignoring the idle
>> > timeout 120 set by the connection, using the brokers max value 0
>>
>> The default value for the C++ broker is 120 while the Java broker is zero.
>> The Java client wants to support heartbeat by default, hence the
>> default value of 120.
>> Heartbeats allows a client to detect a wedged broker and failover
>> accordingly.
>
> If the heartbeats are disabled, the user should know about it, as it
>> could be a configuration error etc..
>> It is infact a warning that the user should pay attention to, hence
>> it's set at WARN level.
>>
>>
>
>
> If this is supposed to be a warning that the end user (who hasn't knowingly
> set a timeout value) can understand, then I would suggest we might reword it
> a bit.

I think that's a good idea.
What did you have in mind ?

> I feel like it's pretty strong to make this a warning when we're not
> sure that the user actually wanted (or at least understood the pros/cons of)
> a heartbeat in the first place

Fair point.
Perhaps if we change the level to INFO, do you think will it convey
the right 'tone' for this message ?

>
>> > [2011-04-25 13:25:10,178]  WARN
>> > {org.apache.qpid.transport.SessionDelegate} -  CLOSED:
>> > [ssn:"10bbf39e-3676-4205-a713-789b3a377cf3"]
>>
>> I guess this was put there (Rafi can correct me if I am wrong) to
>> easily figure out if a session was closed or detached.
>> It is definitely useful for debugging issues, but perhaps we should
>> mark it as INFO rather than WARN.
>>
>>
> This looks like debug to me... unless there is something I am missing
I have no preference here, so debug is fine.

>
> -- Rob
>
>
>
>> The reason for the first warning is that the default heartbeat value in
>> > client properties is 120 whereas the default min and max heartbeat values
>> of
>> > a connection are 0. And it checks if the heartbeat value lies between the
>> > min and max.
>> >
>> > I do not quite understand the reason for the second warning. It just logs
>> > this warning in SessionDelegate.closed.
>> >
>> > Could you please tell me how to get rid of these warning?.
>> >
>> > Thanks,
>> > Danushka
>> >
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project:      http://qpid.apache.org
>> Use/Interact: mailto:[email protected]
>>
>>
>

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to