> On 2011-05-10 09:25:19, Gordon Sim wrote: > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java, > > line 1060 > > <https://reviews.apache.org/r/706/diff/1/?file=18458#file18458line1060> > > > > What happens here if the address doesn't resolve to an existing > > exchange? > > rajith attapattu wrote: > If the address doesn't resolve to an existing exchange or queue an > exception will be thrown if create option is not selected. > But I guess your real question is do we throw an exception if the address > resolves to a queue instead of an exchange. > > At the moment we don't, so we do allow a durable subscription to be > created on a Queue. Not sure if this is JMS compliant though. > What are your thoughts on this? > > Gordon Sim wrote: > AMQSession_0_10.java appears to return AMQDestination.QUEUE_TYPE if there > is neither a queue nor exchange, no? > > In the second case, will the durable subscription work? It doesn't > involve any special codepath assuming binding etc?
Correct, the code does default to queue type. However it then looks at create options and if not specified will throw an exception. But if the queue actually exists (or has instructions to create it) then it should work as expected. I will do a quick test to verify this. - rajith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/706/#review654 ----------------------------------------------------------- On 2011-05-10 03:38:41, rajith attapattu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/706/ > ----------------------------------------------------------- > > (Updated 2011-05-10 03:38:41) > > > Review request for qpid. > > > Summary > ------- > > The attached patch adds code to resolve the address to determine the correct > defualt for the subject field and also to populate the legacy fields. > Also added null checks in both AMQAnyDestination and AMQTopic to prevent any > NPE. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQAnyDestination.java > 1099057 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java > 1099288 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQTopic.java > 1099057 > > Diff: https://reviews.apache.org/r/706/diff > > > Testing > ------- > > > Thanks, > > rajith > >
