[ 
https://issues.apache.org/jira/browse/QPID-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031661#comment-13031661
 ] 

Keith Wall commented on QPID-3207:
----------------------------------

In addition to the failures on the default profile Robbie has noted above, it 
appears that this commit has broken the following test on the *java.0.10* 
profile:

org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testReliabilityOptions

Testcase: testReliabilityOptions took 2.131 sec
        FAILED
expected:<2> but was:<0>
junit.framework.AssertionFailedError: expected:<2> but was:<0>
        at 
org.apache.qpid.test.client.destination.AddressBasedDestinationTest.acceptModeTest(AddressBasedDestinationTest.java:978)
        at 
org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testReliabilityOptions(AddressBasedDestinationTest.java:920)
        at 
org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:234)
        at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:120)




> AMQSession.java close() does not close the consumers with the correct 
> arguments
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3207
>                 URL: https://issues.apache.org/jira/browse/QPID-3207
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.10
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: 0.11
>
>
> When the AMQSession.java close() is invoked it will in turn call the "private 
> void closeConsumers(Throwable error) throws JMSException"  method.
> In this method if the error is null then the consumer.close method is called 
> with "sendClose=false".
> I wonder if this is the correct setting. I suspect the intended value is 
> "true".
> The boolean value is used in determining if we should send a message-cancel 
> or not.
> I am not sure why we are not going to send a message cancel in this case, as 
> we haven't encountered a session error and the session is active.
> Note the AMQSession.java closes the session only after the consumers and 
> producers are closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to