[
https://issues.apache.org/jira/browse/QPID-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051312#comment-13051312
]
Robbie Gemmell commented on QPID-3273:
--------------------------------------
The way not to duplicate the enum would just be to declare it in its own file
in the common tree, not exactly a large change and certainly in scope
considering you are adding it just now, but I dont feel strongly about that
given what its used for.
I do fairly strongly disagree with much of your comment about testing though.
Many of our existing systests certainly do suck, but we absolutely should be
ensuring we improve unit test coverage as we go and the clear way to do that is
by adding specifically targeted unit tests of functionality whenever we know we
are changing untested code. We certainly wont improve our testing situation by
perpetuating it.
> JMSDeliveryMode has to be used as a string in a selector
> ---------------------------------------------------------
>
> Key: QPID-3273
> URL: https://issues.apache.org/jira/browse/QPID-3273
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.6, 0.8, 0.10
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.11
>
> Attachments: 0001-QPID-3273.patch
>
>
> Section 3.8.13 of the JMS spec says that JMSDeliveryMode has to be used as a
> string in a selector (i.e. JMSDeliveryMode = 'PERSISTENT').
> But Qpid only supports it as an integer (i.e JMSDeliveryMode = 2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
