[ 
https://issues.apache.org/jira/browse/QPID-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051741#comment-13051741
 ] 

Keith Wall commented on QPID-3307:
----------------------------------

Hi Charith

I think the patch on the whole looks fine.  My comments would be only a) the 
absence of a unit test case and b) bracing style does not match 
https://cwiki.apache.org/qpid/java-coding-standards.html.   I think a unit test 
that exercised the happy/unhappy path with a normal classloader arrangement 
would suffice.  We do already have a system test, ObjectMessageTest, but I 
think we should be striving for more unit tests wherever we can.

cheers Keith.

> ClassNotfound Exception when using Qpid java client in Complex classloading 
> Environments.  
> -------------------------------------------------------------------------------------------
>
>                 Key: QPID-3307
>                 URL: https://issues.apache.org/jira/browse/QPID-3307
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Critical
>         Attachments: QPID-3307_patch.txt, QPID-3307_patch.txt
>
>
> Hi ,
> When we are using qpid client to receive JMSObject in complex class loading 
> environments like web application containers/Osgi environments .There is a 
> scenario where this issues comes. 
> Scenario. 
> In a web application container normally they use a class loader per web app. 
> and if we have qpid client libs at the root classloader level this error can 
> come. The reason for this is Serializable  Object types that are used inside 
> the web app are not visible to the class loader that loads the JMSObject 
> message and unmarshall it.    
> thanks,
> Charith

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to