[
https://issues.apache.org/jira/browse/QPID-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054537#comment-13054537
]
Alex Rudyy commented on QPID-3310:
----------------------------------
Keith,
I reviewed your patch. It seems Ok for me.
The only question I have regarding your work is
Would not it be better to get Subject object in ServerSession from a Connection
object like in example below
public Subject getAuthorizedSubject()
{
return ((ServerConnection)getConnection()).getSubject();
}
rather then keeping a reference to Subject in ServerSession field?
> Principal/Subject refactoring
> -----------------------------
>
> Key: QPID-3310
> URL: https://issues.apache.org/jira/browse/QPID-3310
> Project: Qpid
> Issue Type: Task
> Components: Java Broker
> Affects Versions: 0.10
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: Future
>
> Attachments: 0001-QPID-3310-Principal-Subject-refactoring.patch
>
>
> This task is to refactor the broker to pass through a Subject from the
> authentication layer downwards, rather than a Principal. The motivation for
> this change is to allow the security modules to make decisions based on all
> principals (including Group principals) rather than merely the
> UsernamePrincipal.
> This task will support QPID-3283.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
