----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/987/#review981 -----------------------------------------------------------
Ship it! Looks good to me, Cliff - thanks! - Steve On 2011-07-05 17:54:17, Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/987/ > ----------------------------------------------------------- > > (Updated 2011-07-05 17:54:17) > > > Review request for qpid. > > > Summary > ------- > > This is the same logic as the preceding version with naming fixes and > refinements to DLL cleanup. > > Cleanup now uses Windows DllMain function to allows cleanup after C++ runtime > static destructors. > > > This addresses bug qpid-3256. > https://issues.apache.org/jira/browse/qpid-3256 > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp 1143151 > > Diff: https://reviews.apache.org/r/987/diff > > > Testing > ------- > > Qpid cmake run_tests > > > Thanks, > > Cliff > >
