[
https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064667#comment-13064667
]
jirapos...@reviews.apache.org commented on QPID-3345:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1087/#review1045
-----------------------------------------------------------
Ship it!
I looked at the patch from the client side and it looks good to me.
I am happy with the direction you are taking.
- rajith
On 2011-07-12 09:38:50, Keith Wall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1087/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-12 09:38:50)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. QPID-3345: transport implementations for client/broker sides controllable
via new System Properties and Reflection.
bq.
bq.
bq. This addresses bug QPID-3345.
bq. https://issues.apache.org/jira/browse/QPID-3345
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java
PRE-CREATION
bq.
/trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java
1145481
bq.
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java
1145481
bq.
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java
1145481
bq.
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java
1145481
bq. /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java
1145481
bq.
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java
1145481
bq.
/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java
1145481
bq.
/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java
1145481
bq.
bq. Diff: https://reviews.apache.org/r/1087/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Additional unit test and exercised by existing system test suite
(0-9-1/0-10 code paths)
bq.
bq.
bq. Thanks,
bq.
bq. Keith
bq.
bq.
> Make new transport implementations pluggable
> --------------------------------------------
>
> Key: QPID-3345
> URL: https://issues.apache.org/jira/browse/QPID-3345
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Rajith Attapattu
> Fix For: 0.13
>
> Attachments:
> 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch
>
>
> Allow new transport implementations (those produced by QPID-3342) to be
> loaded by reflection, thus working towards the removal of dependencies on
> Mina by the client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
