----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1087/#review1045 -----------------------------------------------------------
Ship it! I looked at the patch from the client side and it looks good to me. I am happy with the direction you are taking. - rajith On 2011-07-12 09:38:50, Keith Wall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1087/ > ----------------------------------------------------------- > > (Updated 2011-07-12 09:38:50) > > > Review request for qpid. > > > Summary > ------- > > QPID-3345: transport implementations for client/broker sides controllable via > new System Properties and Reflection. > > > This addresses bug QPID-3345. > https://issues.apache.org/jira/browse/QPID-3345 > > > Diffs > ----- > > > /trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/network/TransportTest.java > PRE-CREATION > > /trunk/qpid/java/common/src/test/java/org/apache/qpid/test/utils/QpidTestCase.java > 1145481 > > /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/security/SecurityLayer.java > 1145481 > > /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/Transport.java > 1145481 > > /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/NetworkTransport.java > 1145481 > /trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/Broker.java > 1145481 > > /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java > 1145481 > > /trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Connection.java > 1145481 > > /trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidBrokerTestCase.java > 1145481 > > Diff: https://reviews.apache.org/r/1087/diff > > > Testing > ------- > > Additional unit test and exercised by existing system test suite (0-9-1/0-10 > code paths) > > > Thanks, > > Keith > >
