[
https://issues.apache.org/jira/browse/QPID-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066040#comment-13066040
]
[email protected] commented on QPID-3044:
-----------------------------------------------------
bq. On 2011-07-15 15:40:16, Robbie Gemmell wrote:
bq. > The apparent JBoss 'dependency' for this seems less than ideal. I don't
think we should/can accept something into the Qpid code base when it hasn't
even been attempted to use it with a product that is actually Apache Licence
compatible. I think this really needs to be able to work fully out the box with
something like Geronimo, with additional rather than sole configuration
supplied for JBoss AS.
bq. >
bq. > It probably gets round the letter of the licence, since although the
example actually imports some JBoss annotations it probably gets away with it
because it doesn't look to be built by default (correct?), whereas the adapter
itself either has the bits turned off that are JBoss dependent and/or uses
reflection to avoid the imports. That doesn't really seem to change the fact
you don't appear to be able to use all of the 'optional' features without JBoss
though, which is probably still in violation of the spirit of the licence.
bq. >
bq. > It still appears that there is absolutely zero test coverage for this?
We keep talking about trying to improve our test situation as a project, but
particularly in the Java tree, and additions like this are not helpful.
bq. >
bq. > The code continues to violate the field naming convention we use on the
Java components ( https://cwiki.apache.org/qpid/java-coding-standards.html ),
although in contrast to earlier versions this diff actually has a mixture of
field naming conventions, making it inconsistent as well.
bq.
bq. Andrew Stitcher wrote:
bq. A quick answer to a couple of things -
bq.
bq. The adapter has actually been used with multiple application servers
including JBoss and Websphere. Also I believe that the TCK testing actually
uses Sun/Oracles reference app server (I didn't do the TCK testing myself).
bq.
bq. It's not at all clear to me why the licensing of the App server
matters for this code as the resource adapter should work for all. So you're
only talking about the default configuration, why shouldn't the default
configuration be JBoss? Its license is LGPL which is compatible with the Apache
License, but I'm not even sure that this is relevant.
bq.
bq. I thought we hashed out the "testing" issue before on the dev list -
in short there is little coherent/useful that you could add to unit tests for
the JCA as it's nearly all straight delegation to the JMS client. And including
an appserver into our java tree just to do unit testing seems fantastic
overhead. There appears to be little in between. The example code provides a
reasonable smoke test (given that you've installed an app server) which I
believe is as good as any unit tests would be.
There is no real 'dependency' on JBoss, the sample configuration file is there
to provide a convenient starting point for that particular application server
but does necessitate it's use. The adapter has been tested in Weblogic as well
as in Websphere. Since both these application servers do not require an XML
configuration file, none has been provided. In sum the *-ds.xml file, is
provided as a convenience, not a requirement.
There is one specific JBoss annotation on QpidListener that is there simply to
which RAR file is in use. This is a requirement of JBoss but can be removed in
favor of an ejb-jar.xml file if you think this would be more acceptable.
The adapter itself has no dependency on JBoss, it is a standard resource
adapter that conforms to the 1.5 JCA specification and as such is application
server agnostic.
bq. On 2011-07-15 15:40:16, Robbie Gemmell wrote:
bq. > /trunk/qpid/java/eclipse-projects/.gitignore, lines 1-2
bq. > <https://reviews.apache.org/r/441/diff/4/?file=25573#file25573line1>
bq. >
bq. > Do we need an 'empty' directory in the repository for this?
bq. >
bq. > We have plenty of directories in the Java tree as it is without
adding redundant (for me at least) ones. Could this instead be added to the
existing global .gitignore, or a new one be added in the Java directory to
ignore the subdirectory and its contents for those that actually wish to create
it?
bq.
bq. Andrew Stitcher wrote:
bq. Oops, that was meant to be removed, I'll get rid of it.
I agree, these should have never been checked in.
bq. On 2011-07-15 15:40:16, Robbie Gemmell wrote:
bq. > /trunk/qpid/java/jca/example/build.xml, line 41
bq. > <https://reviews.apache.org/r/441/diff/4/?file=25579#file25579line41>
bq. >
bq. > Out of date hard coded value. Can we use the existing variables to
keep this up to date?
bq.
bq. Andrew Stitcher wrote:
bq. Good idea - I'll look at that
Agreed, a better strategy should be determined for this value.
bq. On 2011-07-15 15:40:16, Robbie Gemmell wrote:
bq. > /trunk/qpid/java/jca/example/build.xml, lines 208-211
bq. > <https://reviews.apache.org/r/441/diff/4/?file=25579#file25579line208>
bq. >
bq. > Out of date hard coded values. (project version as before, and we
also just upgraded to mina 1.1.7)
bq.
bq. Andrew Stitcher wrote:
bq. Yes I noticed the mina upgrade - that's good as it removes the
backport dependency
See above.
bq. On 2011-07-15 15:40:16, Robbie Gemmell wrote:
bq. >
/trunk/qpid/java/jca/example/src/qpid/jca/example/web/QpidTestServlet.java,
lines 42-43
bq. > <https://reviews.apache.org/r/441/diff/4/?file=25590#file25590line42>
bq. >
bq. > There are tab characters instead of spaces in several places within
this file.
bq.
bq. Andrew Stitcher wrote:
bq. Yeah I noticed there are some remaining space problems in the code -
I'll try to get rid of them.
Agreed. Will fix.
- Weston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/#review1077
-----------------------------------------------------------
On 2011-07-14 22:39:37, Andrew Stitcher wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-14 22:39:37)
bq.
bq.
bq. Review request for qpid, Gordon Sim, Andrew Kennedy, Robbie Gemmell,
rajith attapattu, and Weston Price.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review for a qpid JCA resource adapter.
bq.
bq. So far no build infrastructure is included.
bq.
bq. I'd also like an opinion as to whether java/jca is the appropriate name
for this (I'm thinking perhaps java/ra would be more usual).
bq.
bq. Any and all comments welcome.
bq.
bq.
bq. This addresses bug QPID-3044.
bq. https://issues.apache.org/jira/browse/QPID-3044
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN
bq. /trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java
PRE-CREATION
bq. /trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidConnectionFactoryProxy.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidDestinationProxy.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidQueue.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidTopic.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/AdminObjectFactory.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidBindingURL.java
PRE-CREATION
bq. /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueBrowser.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java
PRE-CREATION
bq. /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java
PRE-CREATION
bq. /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/example/src/qpid/jca/example/web/QpidTestServlet.java
PRE-CREATION
bq. /trunk/qpid/java/jca/qpid-jca-ds.xml PRE-CREATION
bq. /trunk/qpid/java/jca/example/conf/application.xml PRE-CREATION
bq. /trunk/qpid/java/jca/example/conf/qpid-jca-ds.xml PRE-CREATION
bq. /trunk/qpid/java/jca/example/conf/web.xml PRE-CREATION
bq. /trunk/qpid/java/jca/example/src/qpid/jca/example/QpidClient.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/example/src/qpid/jca/example/QpidStandaloneClient.java
PRE-CREATION
bq. /trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidListener.java
PRE-CREATION
bq. /trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTest.java
PRE-CREATION
bq. /trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTestBean.java
PRE-CREATION
bq. /trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTestLocal.java
PRE-CREATION
bq.
/trunk/qpid/java/jca/example/src/qpid/jca/example/ejb/QpidTestRemote.java
PRE-CREATION
bq. /trunk/qpid/java/build.deps 1070497
bq. /trunk/qpid/java/build.xml 1070497
bq.
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java
1070497
bq.
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/TopicPublisherAdapter.java
1070497
bq. /trunk/qpid/java/eclipse-projects/.gitignore PRE-CREATION
bq. /trunk/qpid/java/jca/README-JBOSS.txt PRE-CREATION
bq. /trunk/qpid/java/jca/README.txt PRE-CREATION
bq. /trunk/qpid/java/jca/build.xml PRE-CREATION
bq. /trunk/qpid/java/jca/example/.gitignore PRE-CREATION
bq. /trunk/qpid/java/jca/example/README PRE-CREATION
bq. /trunk/qpid/java/jca/example/build.xml PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. This code is now substantially the same as tested by Red Hat, passes the
TCK.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> Implement JCA Adapter for Java JMS client
> -----------------------------------------
>
> Key: QPID-3044
> URL: https://issues.apache.org/jira/browse/QPID-3044
> Project: Qpid
> Issue Type: New Feature
> Components: Java Client
> Affects Versions: 0.8, 0.9, 0.10
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Labels: JCA, JMS, Java, qpid
> Fix For: 0.11
>
>
> Currently there is no way to integrate the use of Qpid messaging into a Java
> Application Server.
> The solution is to create a JCA (J2EE Connector Architecture) adapter to allow
> the Qpid JMS client to correctly work with the J2EE container.
> This is an entirely new Java component, but may require small amounts of
> change to the
> JMS client code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
