[
https://issues.apache.org/jira/browse/QPID-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073211#comment-13073211
]
Robbie Gemmell commented on QPID-3319:
--------------------------------------
Hi Srinath, Sorry for the delayed reply, I am/have been on holiday as well.
Given many of the issues I raised with the patch previously still apply after
the update, I really wouldnt be comfortable committing it as-is.
I had actually already looked into fixing the leaks in the existing
implementation previously and just hadnt got time to finish it, so I have
completed that work and it is now committed on trunk. It addresses a number of
different possible leaks that were present and ensures the list always removes
the Subscription immediately rather than the sometimes-lazily method used
before, additionally avoiding the most troublesome leak in the form of the
'lastSubscriptionNode' reference in the queue leaking Subscriptions that the
SubscriptionList itself can no longer reach by moving that functionality into
the list itself. As the queue no longer maintains that reference at all, it
also no longer leaks that specific Subscription either (which happens if the
reference is never updated after the Subscription is unregistered). The changes
are committed via QPID-3064 and QPID-3157.
Just for any future patches you have, the updated patch doesnt conform to the
'braces on new lines' aspect of the code style.
I am going to mark this RtR, for closure alongside QPID-3157.
> org.apache.qpid.server.subscription.SubscriptionList leaks memory
> -----------------------------------------------------------------
>
> Key: QPID-3319
> URL: https://issues.apache.org/jira/browse/QPID-3319
> Project: Qpid
> Issue Type: Bug
> Reporter: Danushka Menikkumbura
> Assignee: Robbie Gemmell
> Priority: Critical
> Attachments: QPID-3319-26-07-2011.patch, QPID-3319-26-07-2011.patch,
> QPID-3319.2.patch, QPID-3319.3.patch, QPID-3319.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
