----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1292/#review1293 -----------------------------------------------------------
Ship it! - Gordon On 2011-08-04 18:28:10, Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1292/ > ----------------------------------------------------------- > > (Updated 2011-08-04 18:28:10) > > > Review request for qpid and Gordon Sim. > > > Summary > ------- > > Bug occurred due to state change in object -without- updating the clone of > the object. The clone "lost" the state change, and the message was not > correctly cleaned up. This change introduces a proper copy constructor and > creates the copy after all state has been updated. > > > This addresses bug qpid-3394. > https://issues.apache.org/jira/browse/qpid-3394 > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1153918 > /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1153918 > > Diff: https://reviews.apache.org/r/1292/diff > > > Testing > ------- > > in progress. > > > Thanks, > > Kenneth > >
