> On 2011-08-16 09:08:13, Gordon Sim wrote: > > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp, line 122 > > <https://reviews.apache.org/r/1312/diff/2/?file=32700#file32700line122> > > > > I don't think match should be part of the MessageAllocator interface. I > > think the filter perhaps should include a filter-type identifier which can > > be used to determine how the rest of the map should be interpreted. > > > > We may in future want to use the same filter on different types of > > queue, or different filters on the same type of queue.
Yes, this can be moved out of the MessageAllocator. Can you give me a little more detail as to how you think the filter & filter type should be represented? I'm thinking that we'd create a filter predicate based on the map, and that the move/reroute/purge methods would iterate over the messages applying the filter predicate (probably using the return value as the predicate to the removeIf). Does that make sense? - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1312/#review1472 ----------------------------------------------------------- On 2011-08-16 00:35:20, Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1312/ > ----------------------------------------------------------- > > (Updated 2011-08-16 00:35:20) > > > Review request for qpid. > > > Summary > ------- > > Some initial refactoring of Queue/Consumer interface to allow for message > grouping support. Very preliminary. > > > This addresses bug qpid-3346. > https://issues.apache.org/jira/browse/qpid-3346 > > > Diffs > ----- > > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.h 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.cpp 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Fairshare.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.h 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.h 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.cpp 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Messages.h 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.h 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1144324 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueEvents.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueObserver.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueuePolicy.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1144319 > /branches/qpid-3346/qpid/cpp/src/qpid/cluster/Connection.cpp 1144319 > /branches/qpid-3346/qpid/cpp/src/tests/QueueTest.cpp 1144319 > /branches/qpid-3346/qpid/specs/management-schema.xml 1144324 > /branches/qpid-3346/qpid/tests/src/py/qpid_tests/broker_0_10/management.py > 1144324 > > Diff: https://reviews.apache.org/r/1312/diff > > > Testing > ------- > > minimal - passes unit tests on linux. > > > Thanks, > > Kenneth > >
