----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1645/#review1650 -----------------------------------------------------------
Ship it! Good job! Makes a tricky problem look easy and the tests look good as well. - Gordon On 2011-08-24 21:12:24, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1645/ > ----------------------------------------------------------- > > (Updated 2011-08-24 21:12:24) > > > Review request for qpid, Gordon Sim and Kenneth Giusti. > > > Summary > ------- > > QPID-3384: Enable DTX transactions in a cluster. > > Functionality appears to work but I'm not happy that its sufficiently tested. > I'd welcome suggestions on what else could be tested and how we can automate > more realistic system tests for use of DTX. > > NOTE: there are a bunch of gratuitous whitespace changes, just click "ignore > whitespace changes" at the top of the diff. > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/Msg.h 1161178 > /trunk/qpid/cpp/rubygen/amqpgen.rb 1161178 > /trunk/qpid/cpp/src/Makefile.am 1161178 > /trunk/qpid/cpp/src/qpid/Msg.cpp PRE-CREATION > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxAck.h 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxAck.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxBuffer.h 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxBuffer.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxManager.h 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxManager.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxTimeout.h 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxTimeout.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxWorkRecord.h 1161178 > /trunk/qpid/cpp/src/qpid/broker/DtxWorkRecord.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/SemanticState.h 1161178 > /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/TxBuffer.cpp 1161178 > /trunk/qpid/cpp/src/qpid/broker/TxPublish.h 1161178 > /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1161178 > /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1161178 > /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1161178 > /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.h 1161178 > /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1161178 > /trunk/qpid/cpp/src/qpid/cluster/UpdateReceiver.h 1161178 > /trunk/qpid/cpp/src/qpid/log/Statement.cpp 1161178 > /trunk/qpid/cpp/src/tests/brokertest.py 1161178 > /trunk/qpid/cpp/src/tests/cluster_python_tests_failing.txt 1161178 > /trunk/qpid/cpp/src/tests/cluster_tests.py 1161178 > /trunk/qpid/cpp/xml/cluster.xml 1161178 > > Diff: https://reviews.apache.org/r/1645/diff > > > Testing > ------- > > new unit tests, make check , qpid-txtest > > > Thanks, > > Alan > >
