[ 
https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099673#comment-13099673
 ] 

Andrew Kennedy commented on QPID-3459:
--------------------------------------

Agree with Robbie here.

FYI, when implementing, I deliberated between full-on synchronisation and using 
atomic counters, eventually settling for the synchronisation as seen. In 
testing there was no performance difference between the two mechanisms at any 
statistically significant level. Adding more synchronisation would cause 
serialisation of message processing, since the statistics generation happens on 
the delivery path, which is inadvisable.


> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest 
> sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3459
>                 URL: https://issues.apache.org/jira/browse/QPID-3459
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>            Priority: Minor
>         Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at 
> org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at 
> org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at 
> org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to