On 09/29/2011 10:46 AM, Kenneth Giusti wrote:
On 2011-09-28 12:48:39, Alan Conway wrote:
/trunk/qpid/cpp/src/qpid/broker/MessageAllocator.h, line 37
<https://reviews.apache.org/r/1980/diff/3/?file=46024#file46024line37>
How about QueueOrder? It defines the order that consumers see messages. Or
perhaps something like MessageChooser
Kenneth Giusti wrote:
"A Rose by Any Other Name" :)
I had originally thought of calling it MessageSelector... - see below
for my thoughts on the purpose of this class vs Messages class, and why I've
separated the two.
Gordon Sim wrote:
I didn't like MessageSelector because I felt it was likely to be confused
with a selector i.e. filter as specified by a consumer. It is the component
that determines which subscribers are 'allocated' particular messages, hence
the current name.
How about MessageDistributor?
Aside from the outstanding naming issue - is this patch something we want/good
enough for inclusion on trunk for 0.14? We're getting near the close-down
date for including large changes on trunk, and I'd consider this patch a large
change.
As far as the MessageAllocator re-naming: I'm a bit too used to the existing names to
make a good judgment call here. So I did a lookup of Allocate in my thesaurus and
"Distribute" came up in the top ten. I'll go with MessageDistributor unless I
hear otherwise. And to muddy the waters further, here are a few more matches from the
thesaurus for your consideration....
admeasure, allot, apportion, appropriate, budget, cut, designate, dish
out, divvy, earmark, give, grant, mete, set aside, share, slice, appoint,
assign, budget, cut, cut the pie, distribute, divvy, dole, shell out, split up
:)
I'm torn bewtweeen the MessageDivvyer and MessagePieSlicer.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
