[
https://issues.apache.org/jira/browse/QPID-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120964#comment-13120964
]
[email protected] commented on QPID-3514:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2206/#review2339
-----------------------------------------------------------
Ship it!
Patch looks fine to me in general. Only comment is the use of a dummy option to
communicate between SSL and TCP transports seems a little odd. However there
isn't really any better mechanism as yet and changes to allow a 'nicer'
approach - i.e. richer configuration of transports - are probably better done
as a separate patch anyway.
- Gordon
On 2011-10-05 13:34:16, Gordon Sim wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2206/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-05 13:34:16)
bq.
bq.
bq. Review request for Andrew Stitcher, michael goulish and Chug Rolke.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Allow SSL and non-SSL connections on the same port. Patch contributed by
Zane Bitter for use by the Matahari Project.
bq.
bq.
bq. This addresses bug QPID-3514.
bq. https://issues.apache.org/jira/browse/QPID-3514
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp 1179157
bq. /trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp 1179157
bq. /trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h 1179157
bq. /trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.h 1179157
bq. /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1179157
bq. /trunk/qpid/cpp/src/qpid/sys/Socket.h 1179157
bq. /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1179157
bq.
bq. Diff: https://reviews.apache.org/r/2206/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check passes; tested with and without the multiplexing; tested client
authentication; tested SASL EXTERNAL (requires reverting a recent change
unrelated to this, see QPID-3522)
bq.
bq.
bq. Thanks,
bq.
bq. Gordon
bq.
bq.
> Allow SSL and non-SSL connections on the same port
> --------------------------------------------------
>
> Key: QPID-3514
> URL: https://issues.apache.org/jira/browse/QPID-3514
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Zane Bitter
> Attachments: ssl-mux.patch
>
>
> The Matahari Project (http:://matahariproject.org for the uninitiated) has
> run into an issue with our use of Qpid in that IANA policy is now to refuse
> to assign separate TCP ports for SSL/TLS-wrapped versions of protocols, which
> leaves us with only a single port assigned to Matahari.
> We would like to be able to accept both SSL and non-SSL connections on the
> same port.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
