[
https://issues.apache.org/jira/browse/QPID-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126154#comment-13126154
]
jirapos...@reviews.apache.org commented on QPID-3401:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2364/
-----------------------------------------------------------
(Updated 2011-10-12 21:04:03.513495)
Review request for Gordon Sim, Robbie Gemmell, Weston Price, and Keith Wall.
Summary (updated)
-------
The following is a patch that illustrates the changes made to the core client
namely the session, message consumer and producer classes.
(Please note that in order to compile and run the tests you need to get apply
the QPID-3401.patch attached to the JIRA.)
Most of the code removed from the AMQSession_0_10.java have been included in
the new class structure posted as a separate review [
https://reviews.apache.org/r/2366/ ] to ensure clarity.
In summary the changes are,
1. The code now uses AddressBasedDestination if the syntax is ADDR.
2. For address destinations the code now delegates the creation, assertion,
deletion actions to the underlying QpidDestination class via the
AddressBasedDestination.
3. The code also delegates creating of subscriptions.
TODO.
1. Delegate the deleting of subscriptions (minor change which will follow once
this patch is approved)
2. Currently Durable Subscribers want work with AddressBasedDestinations (This
will be done in a follow up patch that will be posted soon).
(AddressBasedDestination, AddressBasedTopic and AddressBasedQueue classes are
included along with the new class structure patch as a separate review).
This addresses bug QPID-3401.
https://issues.apache.org/jira/browse/QPID-3401
Diffs
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
1182391
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
1182391
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java
1182391
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
1182391
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AMQMessageDelegate_0_10.java
1182391
Diff: https://reviews.apache.org/r/2364/diff
Testing
-------
All existing tests in AddressBasedDestination test pass (with the exception of
the Durable subscription test).
Thanks,
rajith
> Refactor address resolution code
> --------------------------------
>
> Key: QPID-3401
> URL: https://issues.apache.org/jira/browse/QPID-3401
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: 0.14
>
> Attachments: class_diagram.png
>
>
> After some thought it seems that the following JIRA's would benefit from some
> reworking of the address resolution code as the original design had a few
> flaws based on incorrect understanding of the address syntax.
> QPID-3265
> QPID-3317
> QPID-3271
> The redesign would be minimal and not very disruptive. The goal is to fix
> certain design flaws in the current code, rather than a complete redesign. I
> am planning to reuse as much code as possible to ensure we don't throw away
> tested code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
