[
https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134102#comment-13134102
]
[email protected] commented on QPID-3346:
-----------------------------------------------------
bq. On 2011-10-22 23:36:00, Andrew Stitcher wrote:
bq. > /trunk/qpid/cpp/src/qpid/sys/unordered_map.h, line 24
bq. > <https://reviews.apache.org/r/2466/diff/1/?file=51487#file51487line24>
bq. >
bq. > This is almost certainly the wrong test. You should be testing the
compiler being used not the platform being compiled for.
bq. > (_WIN32 will be true for the mingw compile, but it uses the gcc
compiler)
Thanks Andrew - I didn't think of that.
I'll replace the _WIN32 check with a check for the definition of _MSC_VER
instead: as per http://msdn.microsoft.com/en-us/library/b0084kay.aspx
- Kenneth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2466/#review2782
-----------------------------------------------------------
On 2011-10-20 13:26:52, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2466/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-20 13:26:52)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Gordon Sim, and Chug Rolke.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Two performance-related tweaks to message group code:
bq. 1) cache the last group lookup
bq. 2) use tr1::unordered_map rather than std::map for group identifier lookup
- no need to keep the group id's in order.
bq.
bq. Probably the most visible change would be for #2: the include path for
unordered_map differs between gnu and windows - please see the included
sys/unordered_map.h header for my "clever" work-around.
bq.
bq.
bq. Simple benchmark before patch:
bq.
bq. [root@mrg44 kgiusti]# qpid-cpp-benchmark -m 1000000 --content-size=8
--repeat=3 --summarize --send-arg="--group-key=GROUP-ID"
--send-arg="--group-size=11" --receive-option
"node:{x-declare:{arguments:{qpid.group_header_key:GROUP-ID,qpid.shared_msg_group:1}}}"
--senders=2 --receivers=2 --send-arg="--group-interleave=3"
bq. send-tp recv-tp l-min l-max l-avg
bq. 52863 52752 0.47 62.65 18.52
bq. 52437 52440 0.53 79.35 19.10
bq. 52042 52070 0.36 87.69 19.26
bq.
bq. after patch:
bq.
bq. [root@mrg44 kgiusti]# qpid-cpp-benchmark -m 1000000 --content-size=8
--repeat=3 --summarize --send-arg="--group-key=GROUP-ID"
--send-arg="--group-size=11" --receive-option
"node:{x-declare:{arguments:{qpid.group_header_key:GROUP-ID,qpid.shared_msg_group:1}}}"
--senders=2 --receivers=2 --send-arg="--group-interleave=3"
bq. send-tp recv-tp l-min l-max l-avg
bq. 55888 55842 0.68 84.53 17.37
bq. 55810 55784 0.46 85.09 17.23
bq. 54776 54750 0.36 77.25 17.46
bq.
bq.
bq. This addresses bug qpid-3346.
bq. https://issues.apache.org/jira/browse/qpid-3346
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/cpp/src/Makefile.am 1186491
bq. /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.h 1186491
bq. /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.cpp 1186491
bq. /trunk/qpid/cpp/src/qpid/sys/unordered_map.h PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2466/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. unit & benchmarking.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Support message grouping with stricted sequence consumption across multiple
> consumers.
> --------------------------------------------------------------------------------------
>
> Key: QPID-3346
> URL: https://issues.apache.org/jira/browse/QPID-3346
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.14
>
> Attachments: UI.txt, msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced
> Consumers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
