I think the version tag on JIRA is just left over from when the issue was originally created by me a month or so ago, but it has been modified since then by Alex to reflect new info as he and Keith worked on it and probably just not had the version updated. I'm not sure there is actually any intention of putting that into the release branch.
Robbie On 7 November 2011 18:32, Justin Ross <[email protected]> wrote: > I have a question about this one. It's called a refactoring, the patch is > somwhat larger than a simple bug fix would typically call for, and it > doesn't seem to address any regression. Should it go to 0.16 instead? > > I don't intend to block the request. I'd like there to be a discussion, > however. > > Justin > > On Mon, 7 Nov 2011, Alex Rudyy (Assigned) (JIRA) wrote: > >> >> [ >> https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Alex Rudyy reassigned QPID-3519: >> -------------------------------- >> >> Assignee: Keith Wall (was: Alex Rudyy) >> >> Keith, >> could you please review and commit attached patch? >> >>> Refactor the logic behind sending of the selector arguments during >>> subscription creation >>> >>> ---------------------------------------------------------------------------------------- >>> >>> Key: QPID-3519 >>> URL: https://issues.apache.org/jira/browse/QPID-3519 >>> Project: Qpid >>> Issue Type: Bug >>> Components: Java Client >>> Reporter: Robbie Gemmell >>> Assignee: Keith Wall >>> Fix For: 0.14 >>> >>> Attachments: >>> 0001-QPID-3519-refactor-consumer-argument-handling.patch >>> >>> >>> In current implementation the FieldTable with JMS selector is created in >>> AMQSession#createConsumerImpl. >>> The 0-8 MessageConsumer code creates a new FieldTable objects when >>> sending its BasicConsime method. >>> The 0-10 AMQSession code does send an arguments map sourced from the >>> consumer when doing the 'sendConsume' method. >>> Also, both clients send FieldTable with the selector argument they do it >>> using different FieldTable objects. >>> This needs to be improved to allow both clients to reuse the same code. >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> >> >> --------------------------------------------------------------------- >> Apache Qpid - AMQP Messaging Implementation >> Project: http://qpid.apache.org >> Use/Interact: mailto:[email protected] >> >> > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > > --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
