-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2832/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Robbie Gemmell, Weston Price, and
Oleksandr Rudyy.
Summary
-------
This attempts to fix one of the issues related to the handling of Message
credits. See QPID-3602 for an overall picture of the various issues.
This particular patch does the following.
1. When the connection is stopped, it sends message.stop() & releases all
messages in the prefetch buffer.
2. It will also release any messages (that were in flight) that comes after the
connection is stopped. (*)
(*) This interferes with the immediate_prefetch feature. However I don't know
if immediate prefetch is really required in the 0-10 path.
As always comments, suggestions & criticisms are equally welcomed.
This addresses bug QPID-3604.
https://issues.apache.org/jira/browse/QPID-3604
Diffs
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java
1202228
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
1202228
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/client/prefetch/PrefetchBehaviourTest.java
1202228
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java
1202228
Diff: https://reviews.apache.org/r/2832/diff
Testing
-------
See PrefetchBehaviourTest#testConnectionStop for more details.
Thanks,
rajith
