[
https://issues.apache.org/jira/browse/QPID-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179580#comment-13179580
]
[email protected] commented on QPID-3690:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3331/#review4183
-----------------------------------------------------------
Ship it!
Only minor comments
/trunk/qpid/cpp/src/qpid/broker/Bridge.h
<https://reviews.apache.org/r/3331/#comment9418>
I'd prefer returning strings by value rather than const ref. Returning a
ref is a race condition if the string referenced is potentially deleted in a
different thread. Probably not the case here but I'd prefer to keep a simple
convention of return by value. The cost of an atomic counter inc/dec is pretty
small and will be paid anyway if the caller assigns the return value to another
string.
/trunk/qpid/cpp/src/qpid/broker/Link.cpp
<https://reviews.apache.org/r/3331/#comment9419>
Why no log message here? Bridge connecting seems like a significant event.
/trunk/qpid/cpp/src/qpid/broker/Link.cpp
<https://reviews.apache.org/r/3331/#comment9420>
I agree that this is OK.
/trunk/qpid/cpp/src/qpid/broker/Link.cpp
<https://reviews.apache.org/r/3331/#comment9421>
Where (which class & thread) do we detect failure of a link connection to
call this? Will it be called multiple times if multiple connections fail?
/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp
<https://reviews.apache.org/r/3331/#comment9423>
Should be updateAddressLH.
- Alan
On 2011-12-29 03:04:30, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3331/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-29 03:04:30)
bq.
bq.
bq. Review request for Alan Conway, Gordon Sim, michael goulish, and Ted Ross.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed set of changes that will create a new connection for each bridge
that is created on a link.
bq.
bq.
bq. This addresses bug QPID-3690.
bq. https://issues.apache.org/jira/browse/QPID-3690
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1225178
bq. /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1225178
bq. /trunk/qpid/cpp/src/qpid/broker/Link.h 1225178
bq. /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1225178
bq. /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h 1225178
bq. /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1225178
bq. /trunk/qpid/cpp/src/tests/federation.py 1225178
bq. /trunk/qpid/specs/management-schema.xml 1225178
bq. /trunk/qpid/tools/src/py/qpid-tool 1225178
bq.
bq. Diff: https://reviews.apache.org/r/3331/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Allocate a connection per federation bridge (route)
> ---------------------------------------------------
>
> Key: QPID-3690
> URL: https://issues.apache.org/jira/browse/QPID-3690
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.14
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Minor
> Fix For: 0.15
>
>
> All routes configured between two federated brokers share the same underlying
> connection. Since a connection can be serviced by only one thread, all
> traffic flowing over those routes will be serviced by just one thread.
> If a connection can be allocated for each route instead, then the traffic for
> each route could be handled by its own thread, allowing better scaling of
> federation links in a multiprocessor environment.
> Example: adding two routes to forward from queue1 and queue2 to exchange1 on
> a peer:
> qpid-route queue add broker1.fizzbin.com broker2.fizzbin.com exchange1 queue1
> qpid-route queue add broker1.fizzbin.com broker2.fizzbin.com exchange1 queue2
> with today's implementation, a single thread would be used to forward the
> traffic from both queue1 and queue2. If a connection is allocated to each
> route, then each queue's traffic could be serviced by its own thread.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
