[
https://issues.apache.org/jira/browse/QPID-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180250#comment-13180250
]
[email protected] commented on QPID-3630:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3388/#review4195
-----------------------------------------------------------
Looks good! This only covers the broker side. It would be ideal to also remove
the client side support as it will now be entirely useless. The original
inclusion of the feature was:
http://svn.apache.org/viewvc?view=revision&revision=738247 which should help
identifying the code to remove. (Tracking use of
qpid::client::SessionImpl::sendMsgCredit would perhaps also be a good entry
point). ALso worth getting Andrew Stitcher to review as the original author.
- Gordon
On 2012-01-04 21:18:13, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3388/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-04 21:18:13)
bq.
bq.
bq. Review request for qpid and Gordon Sim.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The 0.14 release deprecates the max-session-rate feature. This patch
removes the code from the C++ broker.
bq.
bq.
bq. This addresses bug qpid-3630.
bq. https://issues.apache.org/jira/browse/qpid-3630
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163
bq. /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163
bq. /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163
bq. /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163
bq. /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163
bq. /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163
bq. /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163
bq. /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163
bq. /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163
bq. /trunk/qpid/cpp/src/tests/Makefile.am 1227163
bq. /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163
bq.
bq. Diff: https://reviews.apache.org/r/3388/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. cmake, automake, and unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Remove the "max-session-rate" feature in the C++ Broker.
> --------------------------------------------------------
>
> Key: QPID-3630
> URL: https://issues.apache.org/jira/browse/QPID-3630
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.15
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Trivial
> Fix For: 0.15
>
>
> Feature has be deprecated as of 0.14 release. Remove for 0.16.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
