----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3546/#review4469 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/Bridge.cpp <https://reviews.apache.org/r/3546/#comment10022> This changes the format of data as stored. Probably worth at least detecting that and giving a clearer message. (e.g. change the short string identifier to bridge-v2 and fail to load older bridge definitions) /trunk/qpid/cpp/src/qpid/broker/Broker.cpp <https://reviews.apache.org/r/3546/#comment10033> Given the indexing is changed, and previously I believe that was used to locate the link in order to create a bridge on it, I wonder whether this would break an old qpid-route for example? To be clear that is not a real concern to me. I am fine with changing the schema in a non-backward compatible way. However it would be best to be explicit about it (e.g. simply fail on this method as unsupported) and if we were breaking the schema it might be worth seeing if there is anything else we want to change (i.e. bundle up some breaking changes). /trunk/qpid/cpp/src/qpid/broker/Connection.cpp <https://reviews.apache.org/r/3546/#comment10031> assuming the reordering here is necessary, it might be worth a comment explaining why (to prevent it getting reordered incorrectly in any future changes) /trunk/qpid/cpp/src/qpid/broker/Link.h <https://reviews.apache.org/r/3546/#comment10032> no need for const on return type as its not a reference /trunk/qpid/specs/management-schema.xml <https://reviews.apache.org/r/3546/#comment10035> I'm not so keen on objIds... not saying it is wrong, just that its an aspect of QMf I feel uncomfortable with for broker management... Being able to easily get at the connection currently in use by a link is certainly important though - Gordon On 2012-01-19 14:22:45, Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3546/ > ----------------------------------------------------------- > > (Updated 2012-01-19 14:22:45) > > > Review request for qpid, Alan Conway, Gordon Sim, michael goulish, and Ted > Ross. > > > Summary > ------- > > This patch modifies the way the broker's Link and Bridge objects are > identified and managed. Specifically: > > 1) both Bridge and Links are now identified by explict names assigned by > management, rather than destination host/port info. > - names beginning with the prefix "qpid." are reserved for qpidd internal > use. > - for backward compatibility, if no name is assigned on creation, the > broker will generate a name based on UUID > 2) the corresponding QMF objects have been updated accordingly, with the > additions of: > - the QMF Link object has been updated to provide a reference to the > corresponding Connection > - the QMF Link object has been modified to allow the > host/port/connectionRef to change on failover > - the QMF Bridge object has been modified to allow the Channel identifier > to change (allowing Bridges to be reassigned to different links in the future) > 3) Links/Bridges may now be created/deleted via the QMF Broker's generic > "create" and "delete" methods > 4) Some consolidation of the Link/Bridge creation APIs, specifically: > - Link/Bridges are created via calls to the LinkRegistry's "declare()" > methods > - Link/Bridges are removed by calling their corresponding "destroy()" > methods > > More importantly, the above changes make it possible to create multiple Links > between the same two brokers. This can be done by creating Links to the same > destinations with different names. This is a change from the existing > behavior, which uses the destination host/port as the unique Link identifier. > > > This addresses bug qpid-3767. > https://issues.apache.org/jira/browse/qpid-3767 > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1233125 > /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1233125 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1233125 > /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1233125 > /trunk/qpid/cpp/src/qpid/broker/Link.h 1233125 > /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1233125 > /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h 1233125 > /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1233125 > /trunk/qpid/cpp/src/tests/federation.py 1233125 > /trunk/qpid/specs/management-schema.xml 1233125 > > Diff: https://reviews.apache.org/r/3546/diff > > > Testing > ------- > > This patch fails to pass some of the cluster tests - I'm investigating this > now. All non-cluster federation tests where passing (prior to my latest > rebase). > > Work remains, but I wanted to get this patch out for discussion before going > much farther. > > > Thanks, > > Kenneth > >
