> On 2012-01-23 21:27:36, Rafael Schloming wrote: > > /trunk/qpid/python/qpid/delegates.py, line 163 > > <https://reviews.apache.org/r/3595/diff/1/?file=70360#file70360line163> > > > > This line looks suspicious. Should that actually be > > kwargs.get("client_properties",{})?
Yes, sorry about that. I had some trouble with the c++ makefile copying python code around, was not running what I thought I was. The second diff should be correct. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3595/#review4540 ----------------------------------------------------------- On 2012-01-23 22:53:40, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3595/ > ----------------------------------------------------------- > > (Updated 2012-01-23 22:53:40) > > > Review request for qpid. > > > Summary > ------- > > The client-properties can be specified for old-API, new-API and QMF > connections. > > > Diffs > ----- > > /trunk/qpid/cpp/src/tests/test_env.sh.in 1234410 > /trunk/qpid/extras/qmf/src/py/qmf/console.py 1234410 > /trunk/qpid/python/qpid/delegates.py 1234410 > /trunk/qpid/python/qpid/messaging/driver.py 1234410 > /trunk/qpid/python/qpid/messaging/endpoints.py 1234410 > > Diff: https://reviews.apache.org/r/3595/diff > > > Testing > ------- > > > Thanks, > > Alan > >
