[
https://issues.apache.org/jira/browse/QPID-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194150#comment-13194150
]
[email protected] commented on QPID-3571:
-----------------------------------------------------
bq. On 2012-01-05 00:41:30, Steve Huston wrote:
bq. > Nit... there are a few trailing spaces, noted by red in the review diff.
bq. >
bq. > There's a qpid/sys/PipeHandle.h that you may be able to use in the
SignalPipe class, though there may not be too much benefit to that.
bq. >
bq. > In EventStream::next, does the wait on serializer decrease the timeout?
If not, the wait may end up longer than the caller requested.
bq. >
bq. > Other than that, it's good!
Steve, thanks very much for your time reviewing this code... several times!
I will fix the spaces :-)
The timeout (qpid::sys::Duration) is converted to an absolute time
(targetTimeout) prior to entering the loop. The targetTimeout does not need
further adjusting from within the loop.
The pre-existing PipeHandle class exposes read and write calls on the pipe
whereas the poller's SignalPipe hides them (in order to minimize them). The
remaining overlap between them is very small, so I don't think there is much to
be gained by trying to re-jig either one.
- Cliff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3386/#review4192
-----------------------------------------------------------
On 2012-01-04 20:12:57, Cliff Jansen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3386/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-04 20:12:57)
bq.
bq.
bq. Review request for qpid, Andrew Stitcher, Ted Ross, and Steve Huston.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Portable qpid::sys::Poller implementation for Posix systems.
bq.
bq. Modelled as closely as possible to the EpollPoller implementation.
bq.
bq.
bq. This addresses bug QPID-3571.
bq. https://issues.apache.org/jira/browse/QPID-3571
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/posix/PosixPoller.cpp
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3386/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. linux
bq.
bq. solaris (x86, sparc, gcc, native sunstudio compilers)
bq.
bq.
bq. Thanks,
bq.
bq. Cliff
bq.
bq.
> A generic Posix poller implementation
> -------------------------------------
>
> Key: QPID-3571
> URL: https://issues.apache.org/jira/browse/QPID-3571
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client
> Affects Versions: Future
> Environment: Platforms that support the posix definition of the
> poll() call.
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Attachments: QPID-3571-1.patch
>
>
> An implementation of qpid::sys::Poller that is portable to any OS that
> supports poll() (as defined in the posix specification for sockets and pipes)
> is useful for future porting work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
