[
https://issues.apache.org/jira/browse/QPID-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198130#comment-13198130
]
[email protected] commented on QPID-3481:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3724/#review4757
-----------------------------------------------------------
Ship it!
One minor question (see below) - otherwise looks fine.
trunk/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/3724/#comment10484>
If deleted, would invoking populate here result in (other) consumers being
scheduled to consume from this queue although the message have not been
requeued to it?
- Kenneth
On 2012-02-01 19:51:00, Ted Ross wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3724/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-01 19:51:00)
bq.
bq.
bq. Review request for Gordon Sim and Kenneth Giusti.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch makes one change that fixes the reported bug:
bq.
bq. Messages that are requeued from a subscription (due to closing or release)
to a deleted queue are routed through that queue's alternate exchange if one
was configured. Previously, requeued messages were placed back on the queue
regardless of whether it had been deleted.
bq.
bq.
bq. This addresses bug QPID-3481.
bq. https://issues.apache.org/jira/browse/QPID-3481
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1239252
bq.
bq. Diff: https://reviews.apache.org/r/3724/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passes "make check"
bq. The fix to QPID-3481 has been verified.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> Acquired messages are not sent to alternate exchange when queue is deleted
> and receiver's session closed
> --------------------------------------------------------------------------------------------------------
>
> Key: QPID-3481
> URL: https://issues.apache.org/jira/browse/QPID-3481
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Reporter: Andy Goldstein
> Assignee: Ted Ross
> Priority: Minor
> Attachments: QPID-3481.diff, QPID-3481.patch
>
>
> Currently, the broker will lose messages in the following scenario:
> 1. Client creates receiver to a queue (queue has an alternate exchange
> configured)
> 2. Client acquires message from queue
> 3. Client closes receiver (with delete:always or delete:receiver)
> 4. Client closes session
> We expect that the messages should be sent to the now-deleted queue's
> alternate exchange if/when they are released.
> Messages are not sent to the alternate exchange immediately upon closure of
> the receiver because the client still has acquired messages; this is fine,
> but when the client either releases the messages or closes the session, these
> messages should be sent to the alternate exchange.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
