[
https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200381#comment-13200381
]
Keith Wall commented on QPID-3810:
----------------------------------
Hi Robbie,
A couple of comments, most of which could be equally applied to the previous
version:
1) In the InterruptedException catch block, we should either re-interrupt
ourselves, or set _closed = true, to make sure that the AcceptingThread
responds correctly to an interrupt and shuts itself down.
2) In the event of a RuntimeException (line 223) or IOException (line 227), we
should close any (non-null) Socket that was accepted (line 206) to avoid a
potential socket leak and ensure that the peer gets a exception.
3) Guard the new debug in the finally with isDebugEnabled.
HTH, Keith.
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions
> such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering
> IOExceptions such as too many open files. It should instead catch the
> Exception and attempt to continue (after a short delay to prevent tight
> spinning throwing such exceptions) and allow broker operation to continue if
> the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
