----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4063/#review5447 -----------------------------------------------------------
Ship it! - Gordon On 2012-02-27 22:26:16, Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4063/ > ----------------------------------------------------------- > > (Updated 2012-02-27 22:26:16) > > > Review request for qpid, Gordon Sim, Ted Ross, and rajith attapattu. > > > Summary > ------- > > This is a diff between branch branches/QPID-3799-acl and trunk. > > With it the code implements: > 1. New rule logic where rules are never deleted. All rules in the ACL file > are processed top to bottom. > 2. New limit logic. > * ACL parameters maxqueuesize and maxqueuecount are renamed to > MAXQUEUESIZEUPPERLIMIT and MAXQUEUECOUNTUPPERLIMIT. > * UPPERLIMIT conditions are not part of 'rule match' criteria. Rather, if > the remaining conditions match the rule then the violation of UPPERLIMIT > conditions cause allow rules to be denied. In deny rules the UPPERLIMIT > conditions have no effect. > * MAXQUEUESIZELOWERLIMIT and MAXQUEUECOUNTLOWERLIMIT are like their > UPPERLIMIT counterparts but are enforced as lower bounds on qpid.max_size > queue options. > * New enumeration so that name strings specified by files are separate from > named objects specified by run-time code. > 3. Logging changes: Logs start with "ACL:". New log entries added to aid in > debugging ACL processing. > 4. New features tested in acl.py. > 5. Whitespace and general line width shortening. > > On approval this is ready to be merged back into trunk. > > > This addresses bug QPID-3799. > https://issues.apache.org/jira/browse/QPID-3799 > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/acl/Acl.h 1294348 > trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1294348 > trunk/qpid/cpp/src/qpid/acl/AclData.h 1294348 > trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1294348 > trunk/qpid/cpp/src/qpid/acl/AclReader.h 1294348 > trunk/qpid/cpp/src/qpid/acl/AclReader.cpp 1294348 > trunk/qpid/cpp/src/qpid/acl/AclValidator.h 1294348 > trunk/qpid/cpp/src/qpid/acl/AclValidator.cpp 1294348 > trunk/qpid/cpp/src/qpid/broker/AclModule.h 1294348 > trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.h 1294348 > trunk/qpid/cpp/src/qpid/broker/SemanticState.h 1294348 > trunk/qpid/cpp/src/tests/acl.py 1294348 > > Diff: https://reviews.apache.org/r/4063/diff > > > Testing > ------- > > Tests added and passed. > > > Thanks, > > Chug > >
