On Fri, 2012-03-02 at 11:26 -0500, Alan Conway wrote: > On 03/02/2012 11:15 AM, Andrew Stitcher wrote: > > On Fri, 2012-03-02 at 10:58 -0500, Alan Conway wrote: > >> ... > >> > >> I am not keen on using plain pointers in the API, they make memory > >> management > >> ambiguous and error prone. If we don't want to use boost, we should > >> implement > >> our own ref-counting smart pointers for the API. We already have one such > >> implementation for the Handles in the qpid::messaging API we could use > >> that or > >> duplicate it if we don't want to have dependencies from store plugins on > >> the > >> messaging API > > > > I said not to take the pointers too literally. The important point was > > to avoid needing to pull in definitions for the Handles - our compile > > times are horrendous already can we avoid pulling in any more > > unnecessary header files? > > > > IMO that would be a _necessary_ header file. > ~/qpid/qpid/cpp/include/qpid/messaging/Handle.h contains 19 lines of code, I > don't think compilation time is really a consideration in a design decision > between automated or manual memory management.
I agree. A --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
