----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4261/#review5941 -----------------------------------------------------------
trunk/qpid/cpp/src/qpid/log/Statement.cpp <https://reviews.apache.org/r/4261/#comment12903> I recommend splitting this out into its own (suitably named) function and using that in the constructor here. Incidentally the comment is incorrect in that there is no "return" per se. You can make the function static and inline if efficiency is a specific concern. - Andrew On 2012-03-08 21:52:15, Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4261/ > ----------------------------------------------------------- > > (Updated 2012-03-08 21:52:15) > > > Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim. > > > Summary > ------- > > QPID-3891 C++ Broker --log-function log output is overwhelming. This patch > trims the BOOST_CURRENT_FUNCTION text down to only the > namespace-qualified-functionName. > > > This addresses bug QPID-3891. > https://issues.apache.org/jira/browse/QPID-3891 > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/log/Statement.cpp 1297553 > trunk/qpid/cpp/src/tests/logging.cpp 1297553 > > Diff: https://reviews.apache.org/r/4261/diff > > > Testing > ------- > > Passes modified Unit test. > > > Thanks, > > Chug > >
