----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4525/#review6449 -----------------------------------------------------------
trunk/qpid/cpp/src/qpid/Modules.cpp <https://reviews.apache.org/r/4525/#comment14072> We had this before and took it out. Causes logging before the logging subsystem is properly initialized. Don't remember the exact symptoms but the log text can wind up in inappropriate places. trunk/qpid/cpp/src/qpid/acl/Acl.cpp <https://reviews.apache.org/r/4525/#comment14073> I'm not keen on individual try/catch around every step, it makes the code hard to follow. I'd put a single try-catch around the lot, or just let the exception get thrown: the management infrastructure will catch it and put the exception message in the QMF response. - Alan On 2012-03-27 19:10:23, Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4525/ > ----------------------------------------------------------- > > (Updated 2012-03-27 19:10:23) > > > Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu. > > > Summary > ------- > > Add management methods that let a customer drive arbitrary ACL lookup > queries. > > > This addresses bug QPID-3918. > https://issues.apache.org/jira/browse/QPID-3918 > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/Modules.cpp 1305877 > trunk/qpid/cpp/src/qpid/acl/Acl.h 1305877 > trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1305877 > trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1305877 > trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1305877 > > Diff: https://reviews.apache.org/r/4525/diff > > > Testing > ------- > > > Thanks, > > Chug > >
