-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4788/
-----------------------------------------------------------
Review request for qpid, Gordon Sim and Kenneth Giusti.
Summary
-------
Previously, Link was using sessionHandler::isReady() to determine if a
bridge had failed and needed recovery. However this incorrectcly
recovers bridges that are not yet initialized as well as those that
have failed.
This was causing sporadic core dumps in serveral of the ha_tests.py
tests, in particular test_backup_acquired.
This patch adds a callback to notify the bridge when the session is
detached, and use this as the criteria for recovering a bridge.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Bridge.h 1327518
/trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1327518
/trunk/qpid/cpp/src/qpid/broker/Link.cpp 1327518
/trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1327518
/trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1327518
/trunk/qpid/cpp/src/tests/run_federation_tests 1327518
Diff: https://reviews.apache.org/r/4788/diff
Testing
-------
make check, repeated runs of relevant HA and federation tests.
Thanks,
Alan
