> On 2012-04-19 14:05:36, Gordon Sim wrote: > > trunk/qpid/cpp/include/qpid/sys/Env.h, line 34 > > <https://reviews.apache.org/r/4802/diff/1/?file=102984#file102984line34> > > > > Why is this in the public API? > > Ted Ross wrote: > Good point, I'll move that to src.
On that basis, ship it! - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4802/#review7029 ----------------------------------------------------------- On 2012-04-19 13:56:16, Ted Ross wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4802/ > ----------------------------------------------------------- > > (Updated 2012-04-19 13:56:16) > > > Review request for qpid, Alan Conway and Gordon Sim. > > > Summary > ------- > > This patch allows client applications to use configuration files other than > the installed default. It also allows logging options to be supplied via the > configuration file, not just environment variables. > > > This addresses bug QPID-3510. > https://issues.apache.org/jira/browse/QPID-3510 > > > Diffs > ----- > > trunk/qpid/cpp/include/qpid/sys/Env.h PRE-CREATION > trunk/qpid/cpp/src/CMakeLists.txt 1327943 > trunk/qpid/cpp/src/Makefile.am 1327943 > trunk/qpid/cpp/src/qpid/client/ConnectionImpl.cpp 1327943 > trunk/qpid/cpp/src/qpid/client/LoadPlugins.cpp 1327943 > trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1327943 > trunk/qpid/cpp/src/qpid/sys/posix/Env.cpp PRE-CREATION > trunk/qpid/cpp/src/qpid/sys/windows/Env.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/4802/diff > > > Testing > ------- > > > Thanks, > > Ted > >
