[
https://issues.apache.org/jira/browse/QPID-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260608#comment-13260608
]
[email protected] commented on QPID-3969:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4845/#review7175
-----------------------------------------------------------
I'd like to propose a more general solution to this problem (I'll create a
separate review as I don't see a way to attach a patch to this review).
The schema syntax allows for the specification of a default value for input
arguments and the type-definition file already has an "init" field for the
default value of a type. I propose that the "unmap" generated code use the
argument default, if present, otherwise the default initializer for the data
type.
- Ted
On 2012-04-23 20:50:04, Gordon Sim wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4845/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-23 20:50:04)
bq.
bq.
bq. Review request for Ted Ross.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Arguments for QMFv2 methods may have undefined values if not specified.
E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify a
value for use-alt-exchange, the actual value for that variable is undefined.
The same is true for all bool and int arguments.
bq.
bq.
bq. This addresses bug QPID-3969.
bq. https://issues.apache.org/jira/browse/QPID-3969
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329397
bq.
bq. Diff: https://reviews.apache.org/r/4845/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check passes
bq.
bq.
bq. Thanks,
bq.
bq. Gordon
bq.
bq.
> arguments for QMFv2 methods may have undefined values if not specified
> ----------------------------------------------------------------------
>
> Key: QPID-3969
> URL: https://issues.apache.org/jira/browse/QPID-3969
> Project: Qpid
> Issue Type: Bug
> Components: Qpid Managment Framework
> Affects Versions: 0.16
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.17
>
>
> E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify
> a value for use-alt-exchange, the actual value for that variable is
> undefined. The same is true for all bool and int arguments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
