On May 4, 2012, at 12:38 PM, Weston M. Price wrote:

> 
> On May 4, 2012, at 12:23 PM, Weston M. Price wrote:
> 
>> 
>> On May 4, 2012, at 11:39 AM, Robbie Gemmell wrote:
>> 
>>> You would also need to add an entry to the build.deps file for the new
>>> jar, and update the existing entry for the ra module in build.deps to
>>> say it depends on it.
>> Yep, this I knew, but the question was primarily around where to get/access 
>> the jar. Sounds like it's a manual process versus automated.
>>> 
>>> This also reminds me to bring up something. There is a hack in the
>>> build.deps file for the adapter with a comment saying it has to
>>> duplicate some definitions because the systests module is looking for
>>> jca instead of ra. It wasnt clear to be why the systests module had
>>> been configured to depend on something that doesnt actually exist in
>>> the first place?
>>> 
>> From what I remember, when I was setting this up this was a naming thing 
>> when one project was looking for 'ra' but the jca project itself needed 
>> 'jca'. I remember changing the name and for some reason the artifacts that 
>> were generated suddenly were named qpid-jca-0.x.rar versus qpid-ra-0.x.rar.  
>> Admittedly I didn't dig too deeply. I have some time today to look at it 
>> further. 
>>> Robbie
> Ah, ok, now I remember. The issue seems to be that the in the jca build.xml 
> file, the module is listed as:
> 
> <property name="module.name" value="ra"/>
> 
> While the directory itself is named jca. This was causing issues because the 
> jca project needed ra.libs to build, but the tests didn't know what to do 
> with ra.libs because there is no directory by that name. Unfortunately, it 
> was at a point where we couldn't change things as people had already started 
> to depend on the RAR being named qpid-ra-<version>.rar.
> 
> Probably time to revisit this. 
In looking closer, I believe I can change the module.name to jca (which it 
should be) and just use this to generate the RAR name:

 <property name="module.rar" 
value="${build.lib}/${project.name}-ra-${project.version}.rar"/>

This actually makes a lot more sense as JCA should be the module, while the 
artifact, the resource adapter can still be appropriately named. 

Regards,

Weston
> 
> Weston
>>> 
>> 
>> Thanks again. 
>> 
>> Regards,
>> 
>> Weston
>>> On 4 May 2012 15:41, Weston M. Price <[email protected]> wrote:
>>>> In the JCA example code, we have a dependency on the Servlet API. 
>>>> Currently we include a few JEE jars from Geronimo (ejb, jca etc). I would 
>>>> like the include the geronimo-servlet-spec jar as well. Is it as simple as 
>>>> taking a copy of the jar and putting it in the java/lib directory or is 
>>>> there something more to it?
>>>> 
>>>> Regards,
>>>> 
>>>> Weston
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [email protected]
>>>> For additional commands, e-mail: [email protected]
>>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to