----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4658/#review7940 -----------------------------------------------------------
Just an update on the status. I have already made the changes suggested here. In addition I have also made further changes based on more comments received by Rob Godfrey. The only missing piece (a critical one at that) is the testing. I'm planning to add the unit tests soon. - rajith On 2012-04-05 15:03:30, rajith attapattu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4658/ > ----------------------------------------------------------- > > (Updated 2012-04-05 15:03:30) > > > Review request for qpid, Gordon Sim, Robbie Gemmell, Weston Price, Rafael > Schloming, and Rob Godfrey. > > > Summary > ------- > > The following patch is based on the various discussions we've had on the dev > list about restructing our destination implementation. > As the first phase this patch only includes the new class heirachy. For the > second phase we will tackle the integration into the code base. > > A summary of the desgin is as follows, > > 1. Once initialized with the destination string, the destination objects are > immutable. > 2. There are 2 concrete implementations in the form of QpidTopic and > QpidQueue. > 3. Destinations will be desginated as "Queues" and "Topics" by the users in > the jndi file. This prevents us from having to automagically decide the type. > 4. Both BURL and Address strings are parsed and adapted into a common data > structure. Internally the code will work with this data structure. > 5. The Destination impl does not depend on any other classes, thus allowing > it be used with the current code or the new client. > > (There are 2 oe 3 white space errors that I can't seem to get rid of. It > seems they are comming from the diff process). > > > This addresses bug QPID-3401. > https://issues.apache.org/jira/browse/QPID-3401 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/DestinationStringParser.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/QpidDestination.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/QpidQueue.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/QpidTemporaryQueue.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/QpidTemporaryTopic.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/QpidTopic.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/TemporaryDestinationProvider.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/messaging/Address.java > 1309769 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/messaging/address/AddressException.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/messaging/address/Link.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/messaging/address/Node.java > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/messaging/util/AddressHelper.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4658/diff > > > Testing > ------- > > > Thanks, > > rajith > >
