[
https://issues.apache.org/jira/browse/QPID-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277073#comment-13277073
]
Andrew Stitcher commented on QPID-4004:
---------------------------------------
There are a few bits of cruft in the Buffer class and interface:
* This iterator which actually isn't used by any current code
* record() and restore() member functions which are aren't really safe to use.
[The Buffer class doesn't keep a stack of recorded locations, so you can't
perform
any function calls that might themselves do record()/restore()] This makes it
hard to
reason about locally, and hard to ensure globally.
> qpid::framing::Buffer::Iterator not very useful
> -----------------------------------------------
>
> Key: QPID-4004
> URL: https://issues.apache.org/jira/browse/QPID-4004
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Reporter: Florian Weimer
> Assignee: Andrew Stitcher
> Priority: Minor
>
> The definition of qpid::framing::Buffer::Iterator seems buggy to me. This is
> not a bidirectional iterator. It's not even a forward iterator because the
> iterator state is kept in the referenced buffer object. It is not possible
> to use a pair of such iterators to form a range, so not many algorithms can
> be used on them (at least not in a safe manner).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
