----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5231/#review8098 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/Messages.h <https://reviews.apache.org/r/5231/#comment17625> The problem with this is that it doesn't allow other parts of the broker to 'react' to the truncation. E.g. if the messages are durable they also need to be removed from the store. Management stats may need to be updated as may counters associated with flow control, policy enforcement etc. - Gordon On 2012-05-25 01:30:36, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5231/ > ----------------------------------------------------------- > > (Updated 2012-05-25 01:30:36) > > > Review request for qpid, Gordon Sim and Kenneth Giusti. > > > Summary > ------- > > In the new HA code a backup may sometimes be ahead of the new primary > after a > fail-over. In that case the backup truncates it's queues to the same > position > as the primary so it can continue replicating. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/MessageDeque.h 1342442 > /trunk/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1342442 > /trunk/qpid/cpp/src/qpid/broker/MessageMap.h 1342442 > /trunk/qpid/cpp/src/qpid/broker/MessageMap.cpp 1342442 > /trunk/qpid/cpp/src/qpid/broker/Messages.h 1342442 > /trunk/qpid/cpp/src/qpid/broker/PriorityQueue.h 1342442 > /trunk/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1342442 > /trunk/qpid/cpp/src/qpid/broker/Queue.h 1342442 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1342442 > /trunk/qpid/cpp/src/tests/Makefile.am 1342442 > /trunk/qpid/cpp/src/tests/QueueTest.cpp 1342442 > /trunk/qpid/cpp/src/tests/brokertest.py 1342442 > > Diff: https://reviews.apache.org/r/5231/diff > > > Testing > ------- > > > Thanks, > > Alan > >
