----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5231/#review8161 -----------------------------------------------------------
Ship it! Just noticed a trival typo you might want to clean up before committing.... /trunk/qpid/cpp/src/qpid/broker/MessageMap.h <https://reviews.apache.org/r/5231/#comment17675> ? typo... - Kenneth On 2012-05-28 16:21:49, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5231/ > ----------------------------------------------------------- > > (Updated 2012-05-28 16:21:49) > > > Review request for qpid, Gordon Sim and Kenneth Giusti. > > > Summary > ------- > > In the new HA code a backup may sometimes be ahead of the new primary > after a > fail-over. In that case the backup truncates it's queues to the same > position > as the primary so it can continue replicating. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1343220 > /trunk/qpid/cpp/src/qpid/broker/MessageMap.h 1343220 > /trunk/qpid/cpp/src/qpid/broker/MessageMap.cpp 1343220 > /trunk/qpid/cpp/src/qpid/broker/Messages.h 1343220 > /trunk/qpid/cpp/src/qpid/broker/PriorityQueue.h 1343220 > /trunk/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1343220 > /trunk/qpid/cpp/src/qpid/broker/Queue.h 1343220 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1343220 > /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1343220 > /trunk/qpid/cpp/src/qpid/ha/HaBroker.cpp 1343220 > /trunk/qpid/cpp/src/tests/Makefile.am 1343220 > /trunk/qpid/cpp/src/tests/QueueTest.cpp 1343220 > /trunk/qpid/cpp/src/tests/brokertest.py 1343220 > /trunk/qpid/cpp/src/qpid/broker/MessageDeque.h 1343220 > /trunk/qpid/tools/src/py/.gitignore 1343220 > > Diff: https://reviews.apache.org/r/5231/diff > > > Testing > ------- > > Passing make check, added unit tests to QueueTests.cpp > > > Thanks, > > Alan > >
