> On 2012-05-30 13:22:40, Gordon Sim wrote: > > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp, line 1185 > > <https://reviews.apache.org/r/5253/diff/4/?file=110786#file110786line1185> > > > > Sorry for missing this last time; you could put this in > > ExchangeRegistry::destroy() which would again line up nicely with the > > create event and wouldn't as far as I can see cause any problems.
Done - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5253/#review8207 ----------------------------------------------------------- On 2012-05-30 13:18:17, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5253/ > ----------------------------------------------------------- > > (Updated 2012-05-30 13:18:17) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Summary > ------- > > The HA plugin needs to know when queues are created. This patch creates a > ConfigurationObserver to observe queue and exchange create/delete and > bind/unbind. > The MessageStore API has these hooks but you can't have multiple > MessageStores on a broker, also calls to the MessageStore interface are > conditional on durability which is not what I want for HA. The > ConfigurationObserver calls are placed close to the corresponding > MessageStore calls, except that the create() calls are placed earlier - just > before the queue/exchange is stored in the Registry. That allows an Observer > to effectively abort the creation of the queue/exchange (HA doesn't actually > need this but it seemed like it might be useful) > > How does this look? Any suggestions for better ways to do it? > > > Diffs > ----- > > /trunk/qpid/cpp/src/Makefile.am 1344052 > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1344052 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1344052 > /trunk/qpid/cpp/src/qpid/broker/ConfigurationObserver.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/broker/ConfigurationObservers.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/broker/ConnectionObservers.h 1344052 > /trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1344052 > /trunk/qpid/cpp/src/qpid/broker/Observers.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1344052 > > Diff: https://reviews.apache.org/r/5253/diff > > > Testing > ------- > > make check > > > Thanks, > > Alan > >
